Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_iot_provisioning_template: Properly send type argument on create when configured #38640

Merged
merged 4 commits into from
Aug 1, 2024
Merged

r/aws_iot_provisioning_template: Properly send type argument on create when configured #38640

merged 4 commits into from
Aug 1, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Aug 1, 2024 •
edited
Loading

Description

Correct sets Type for CreateProvisioningTemplate API call.

Relations

Closes #38629.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccIoTProvisioningTemplate_' PKG=iot ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/iot/... -v -count 1 -parallel 3  -run=TestAccIoTProvisioningTemplate_ -timeout 360m
=== RUN   TestAccIoTProvisioningTemplate_basic
=== PAUSE TestAccIoTProvisioningTemplate_basic
=== RUN   TestAccIoTProvisioningTemplate_disappears
=== PAUSE TestAccIoTProvisioningTemplate_disappears
=== RUN   TestAccIoTProvisioningTemplate_tags
=== PAUSE TestAccIoTProvisioningTemplate_tags
=== RUN   TestAccIoTProvisioningTemplate_update
=== PAUSE TestAccIoTProvisioningTemplate_update
=== RUN   TestAccIoTProvisioningTemplate_jitp
=== PAUSE TestAccIoTProvisioningTemplate_jitp
=== CONT  TestAccIoTProvisioningTemplate_basic
=== CONT  TestAccIoTProvisioningTemplate_update
=== CONT  TestAccIoTProvisioningTemplate_jitp
--- PASS: TestAccIoTProvisioningTemplate_jitp (20.71s)
=== CONT  TestAccIoTProvisioningTemplate_tags
--- PASS: TestAccIoTProvisioningTemplate_basic (20.73s)
=== CONT  TestAccIoTProvisioningTemplate_disappears
--- PASS: TestAccIoTProvisioningTemplate_disappears (17.84s)
--- PASS: TestAccIoTProvisioningTemplate_update (42.88s)
--- PASS: TestAccIoTProvisioningTemplate_tags (33.64s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/iot	59.162s

@ewbankkit ewbankkit requested a review from a team as a code owner August 1, 2024 13:52
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iot Issues and PRs that pertain to the iot service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 1, 2024
jar-b
jar-b approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=iot TESTS=TestAccIoTProvisioningTemplate_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/iot/... -v -count 1 -parallel 20 -run='TestAccIoTProvisioningTemplate_'  -timeout 360m
go: downloading github.com/aws/aws-sdk-go-v2/service/storagegateway v1.31.3
=== RUN   TestAccIoTProvisioningTemplate_basic
=== PAUSE TestAccIoTProvisioningTemplate_basic
=== RUN   TestAccIoTProvisioningTemplate_disappears
=== PAUSE TestAccIoTProvisioningTemplate_disappears
=== RUN   TestAccIoTProvisioningTemplate_tags
=== PAUSE TestAccIoTProvisioningTemplate_tags
=== RUN   TestAccIoTProvisioningTemplate_update
=== PAUSE TestAccIoTProvisioningTemplate_update
=== RUN   TestAccIoTProvisioningTemplate_jitp
=== PAUSE TestAccIoTProvisioningTemplate_jitp
=== CONT  TestAccIoTProvisioningTemplate_basic
=== CONT  TestAccIoTProvisioningTemplate_update
=== CONT  TestAccIoTProvisioningTemplate_jitp
=== CONT  TestAccIoTProvisioningTemplate_tags
=== CONT  TestAccIoTProvisioningTemplate_disappears
--- PASS: TestAccIoTProvisioningTemplate_disappears (22.75s)
--- PASS: TestAccIoTProvisioningTemplate_jitp (25.29s)
--- PASS: TestAccIoTProvisioningTemplate_basic (25.37s)
--- PASS: TestAccIoTProvisioningTemplate_tags (42.01s)
--- PASS: TestAccIoTProvisioningTemplate_update (49.78s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/iot        55.860s

@ewbankkit ewbankkit merged commit 18e6a5d into main Aug 1, 2024
41 checks passed
@ewbankkit ewbankkit deleted the b-aws_iot_provisioning_template.type-regression branch August 1, 2024 16:33
@github-actions github-actions bot added this to the v5.61.0 milestone Aug 1, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Aug 1, 2024
Update CHANGELOG.md for #38640
9f913bc
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
service/iot Issues and PRs that pertain to the iot service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.61.0
Development

Successfully merging this pull request may close these issues.

[Bug]: resource/aws_iot_provisioning_template: type JITP not works from version 5.57.0
2 participants
@ewbankkit @jar-b